Unofficial Patch Work

aaro4130
MM2X Super Active User
MM2X Super Active User
Posts: 2402
Joined: Mon May 26, 2008 2:00 am
Location: Canada
Likes received: 1 like

Unofficial Patch Work

Postby aaro4130 » Mon Jul 11, 2016 10:30 am

Image
Last edited by aaro4130 on Tue Jul 12, 2016 10:25 pm, edited 1 time in total.
[img]https://i61.tinypic.com/25zrngo.jpg[/img][color=white]
- Most creative active member
- Most smart active member
- Best MM2 innovation of the year
- Best programmer

[img]https://i60.tinypic.com/2m4c2h5.jpg[/img]
- Most helpful active member[/color]

User avatar
sajmon14
MM2X VIP Member
MM2X VIP Member
Posts: 5319
Joined: Wed Feb 13, 2008 1:00 am
Location: Poland
Contact:

Postby sajmon14 » Mon Jul 11, 2016 1:09 pm

Nice! :)

User avatar
KingAndy
MM2X Very Active User
MM2X Very Active User
Posts: 1113
Joined: Thu Aug 22, 2013 2:00 am
Location: Lisbon, Portugal
Likes received: 1 like
Contact:

Postby KingAndy » Mon Jul 11, 2016 4:42 pm

Sounds very promising. :)
Image
Best active member avatar
Best active member MM1 screenshot-er
Friendliest active member

Image
Most helpful active member
Best MM2 car converter of the year
Best MM2 innovation of the year
Author of the best MM2 mod of the year
Best active user's self amatory site


Image

aaro4130
MM2X Super Active User
MM2X Super Active User
Posts: 2402
Joined: Mon May 26, 2008 2:00 am
Location: Canada
Likes received: 1 like

Postby aaro4130 » Mon Jul 11, 2016 7:48 pm

Another day, another patch :)

Code: Select all

- fixed an issue where the cop chase state was persistent between level loads, causing the incorrect music to fire.
[img]https://i61.tinypic.com/25zrngo.jpg[/img][color=white]
- Most creative active member
- Most smart active member
- Best MM2 innovation of the year
- Best programmer

[img]https://i60.tinypic.com/2m4c2h5.jpg[/img]
- Most helpful active member[/color]

User avatar
Franch88
MM2X Admin
MM2X Admin
Posts: 15703
Joined: Thu May 31, 2007 2:00 am
Location: Italy
Likes received: 1 like
Contact:

Postby Franch88 » Mon Jul 11, 2016 8:41 pm

Looks like you're now continuing that old project of community patch making, you had already fixed some of those things back in that time. :) That's great of you, keep it up with the fixes. :D

PS: when possible, change the topic title with something appropriate. :wink:
Fiat 500 = Italian motorization. Franch88, MM2 eXtreme forum and website Administrator.
|Franch88's MM2 Releases|

User avatar
The_Most_Wanted
MM2X Active User
MM2X Active User
Posts: 960
Joined: Mon Oct 15, 2012 2:00 am
Location: Egypt

Postby The_Most_Wanted » Tue Jul 12, 2016 3:04 am

Awesome! :)
Image
Best Midtown Madness 2 car converter of the year
Best Midtown Madness 2 innovation of the year
Author of the best Midtown Madness 2 mod of the year

Image
Best Midtown Madness 2 breakout of the year
Author of the best Midtown Madness 2 car add-on of the year

Image

User avatar
mm2mm1fan
MM2X Very Active User
MM2X Very Active User
Posts: 1208
Joined: Mon Jul 08, 2013 2:00 am
Location: USA
Contact:

Postby mm2mm1fan » Tue Jul 12, 2016 3:36 am

Sweet! :)
Mostly retired from modifying Midtown Madness games. Nowadays mods Crashday Redline Edition.

Image

aaro4130
MM2X Super Active User
MM2X Super Active User
Posts: 2402
Joined: Mon May 26, 2008 2:00 am
Location: Canada
Likes received: 1 like

Postby aaro4130 » Tue Jul 12, 2016 4:15 pm

Code: Select all

- fixed an issue where buildings could be improperly lit depending on the last selected TOD/Weather settings
(basically fixed wrong PSDL shading when you load a new time of day)
[img]https://i61.tinypic.com/25zrngo.jpg[/img][color=white]
- Most creative active member
- Most smart active member
- Best MM2 innovation of the year
- Best programmer

[img]https://i60.tinypic.com/2m4c2h5.jpg[/img]
- Most helpful active member[/color]

User avatar
dummiesboy
MM2X Super Active User
MM2X Super Active User
Posts: 2426
Joined: Thu Jul 24, 2008 2:00 am
Location: ´Murca
Likes received: 1 like

Postby dummiesboy » Tue Jul 12, 2016 8:18 pm

Code: Select all

- fixed an issue where buildings could be improperly lit depending on the last selected TOD/Weather settings
(basically fixed wrong PSDL shading when you load a new time of day)
Image
Image

User avatar
Franch88
MM2X Admin
MM2X Admin
Posts: 15703
Joined: Thu May 31, 2007 2:00 am
Location: Italy
Likes received: 1 like
Contact:

Postby Franch88 » Tue Jul 12, 2016 8:33 pm

Oh, that's the PSDL buildings facades lightning/coloring issue. I well know the bug of them, great work with fixing it. :D You're done a great amount of fixes so far, keep up the great work! :D
Are they all done in the game EXE with an hex editor? If so, would be good have a patcher that works with any game EXE variant existing.
Fiat 500 = Italian motorization. Franch88, MM2 eXtreme forum and website Administrator.
|Franch88's MM2 Releases|

aaro4130
MM2X Super Active User
MM2X Super Active User
Posts: 2402
Joined: Mon May 26, 2008 2:00 am
Location: Canada
Likes received: 1 like

Postby aaro4130 » Tue Jul 12, 2016 10:26 pm

It may be possible that the CnR crashes are fixed entirely because of this. More testing needed.

Code: Select all

- Potentially fixed a crash related to collisions in CnR
[img]https://i61.tinypic.com/25zrngo.jpg[/img][color=white]
- Most creative active member
- Most smart active member
- Best MM2 innovation of the year
- Best programmer

[img]https://i60.tinypic.com/2m4c2h5.jpg[/img]
- Most helpful active member[/color]

User avatar
dummiesboy
MM2X Super Active User
MM2X Super Active User
Posts: 2426
Joined: Thu Jul 24, 2008 2:00 am
Location: ´Murca
Likes received: 1 like

Postby dummiesboy » Wed Jul 13, 2016 6:28 am

Are they all done in the game EXE with an hex editor? If so, would be good have a patcher that works with any game EXE variant existing.
Basically yes. A script runs and changes the necessary hex bytes, allowing it to work with most versions of the EXE.
It may be possible that the CnR crashes are fixed entirely because of this. More testing needed.

Code: Select all

- Potentially fixed a crash related to collisions in CnR
Well, for the record here, my MM2 is known for being legendarily unstable online. Crashes all the time in CnR, especially in a few particular spots around the cities. After your fix, it was rock steady in these places, even with 400+ props spammed around it. I'd say it works well. :)

Basically what the fix does is change a value in memory from being dynamic to being static. It would occasionally move to an illegal address before the patch, causing a crash. Now that it's static, it never will.
Image

User avatar
Franch88
MM2X Admin
MM2X Admin
Posts: 15703
Joined: Thu May 31, 2007 2:00 am
Location: Italy
Likes received: 1 like
Contact:

Postby Franch88 » Thu Jul 14, 2016 8:27 pm

Well, such fixes must be permanently, they need to be patched. Otherwise, they're going to be applied everytime the game is launched editing the process in memory, like MM2Hack does.

I've a suggestion. Is it possible to avoid that the game crashes if you push the horn button playing cop cars that haven't their basenames present in the vehtypes.csv file? If the basename of a cop car isn't present in that file, the horn button will play the horn sound set in the cop car audio .csv file, if possible.
Fiat 500 = Italian motorization. Franch88, MM2 eXtreme forum and website Administrator.
|Franch88's MM2 Releases|

aaro4130
MM2X Super Active User
MM2X Super Active User
Posts: 2402
Joined: Mon May 26, 2008 2:00 am
Location: Canada
Likes received: 1 like

Postby aaro4130 » Fri Jul 15, 2016 8:41 pm

I've a suggestion. Is it possible to avoid that the game crashes if you push the horn button playing cop cars that haven't their basenames present in the vehtypes.csv file? If the basename of a cop car isn't present in that file, the horn button will play the horn sound set in the cop car audio .csv file, if possible.
Fixed, but instead the siren audio never starts. The lights will, however, still play.

Better than a game crash
[img]https://i61.tinypic.com/25zrngo.jpg[/img][color=white]
- Most creative active member
- Most smart active member
- Best MM2 innovation of the year
- Best programmer

[img]https://i60.tinypic.com/2m4c2h5.jpg[/img]
- Most helpful active member[/color]

User avatar
Franch88
MM2X Admin
MM2X Admin
Posts: 15703
Joined: Thu May 31, 2007 2:00 am
Location: Italy
Likes received: 1 like
Contact:

Postby Franch88 » Fri Jul 15, 2016 8:57 pm

That sounds an interesting result, great work! :wink:
Fiat 500 = Italian motorization. Franch88, MM2 eXtreme forum and website Administrator.
|Franch88's MM2 Releases|